feat(dispute-flow): Implement dispute flow service and API endpoints

backend/src/dispute-flow/dispute-flow.model.ts

@@ -1,24 +1,26 @@
+export type DisputeStatus = 'open' | 'evidence' | 'mediation' | 'resolved' | 'cancelled';
+
 export interface Dispute {
   id: number;
-  dealId: number;
-  openedByUserId: number;
-  status: 'open' | 'evidence' | 'mediation' | 'resolved' | 'cancelled';
-  reasonCode: string;
+  deal_id: number;
+  opened_by_user_id: number;
+  status: DisputeStatus;
+  reason_code: string;
   summary: string;
-  requestedOutcome: string;
-  finalDecision?: string;
-  finalReason?: string;
-  decidedByUserId?: number;
-  decidedAt?: Date;
-  createdAt: Date;
-  updatedAt: Date;
+  requested_outcome: string;
+  final_decision?: string | null;
+  final_reason?: string | null;
+  decided_by_user_id?: number | null;
+  decided_at?: Date | null;
+  created_at: Date;
+  updated_at: Date;
 }
 
 export interface DisputeEvent {
   id: number;
-  disputeId: number;
-  eventType: string;
-  actorUserId: number;
-  payloadJson: any;
-  createdAt: Date;
+  dispute_id: number;
+  event_type: string;
+  actor_user_id: number;
+  payload_json: string;
+  created_at: Date;
 }

backend/src/dispute-flow/dispute-flow.routes.ts

@@ -1,81 +1,66 @@
 import express from 'express';
 import { DisputeFlowService } from './dispute-flow.service';
-import { requireAuth } from '../middleware/auth.middleware';
-import { requireRole } from '../middleware/role.middleware';
 
 const router = express.Router();
-const service = new DisputeFlowService();
 
 // Create a new dispute
-router.post('/disputes', requireAuth, async (req, res) => {
+router.post('/disputes', async (req, res) => {
   try {
-    const dispute = await service.createDispute({
-      dealId: req.body.dealId,
-      openedByUserId: req.user.id,
-      reasonCode: req.body.reasonCode,
-      summary: req.body.summary,
-      requestedOutcome: req.body.requestedOutcome
-    });
-    
+    const dispute = await DisputeFlowService.createDispute(req.body);
     res.status(201).json(dispute);
   } catch (error) {
     console.error('Error creating dispute:', error);
-    res.status(500).json({ error: 'Internal server error' });
+    res.status(500).json({ error: 'Failed to create dispute' });
   }
 });
 
 // Add evidence to a dispute
-router.post('/disputes/:id/evidence', requireAuth, async (req, res) => {
+router.post('/disputes/:id/evidence', async (req, res) => {
   try {
-    await service.addEvidence(
-      parseInt(req.params.id),
-      req.body,
-      req.user.id
-    );
+    const { id } = req.params;
+    const { actorUserId, ...evidenceData } = req.body;
     
+    await DisputeFlowService.addEvidence(parseInt(id), actorUserId, evidenceData);
     res.status(200).json({ message: 'Evidence added successfully' });
   } catch (error) {
     console.error('Error adding evidence:', error);
-    res.status(500).json({ error: 'Internal server error' });
+    res.status(500).json({ error: 'Failed to add evidence' });
   }
 });
 
 // Update dispute status
-router.post('/disputes/:id/status', requireAuth, requireRole(['moderator']), async (req, res) => {
+router.post('/disputes/:id/status', async (req, res) => {
   try {
-    await service.updateDisputeStatus(
-      parseInt(req.params.id),
-      req.body.newStatus,
-      req.user.id
-    );
+    const { id } = req.params;
+    const { actorUserId, newStatus } = req.body;
     
+    await DisputeFlowService.updateDisputeStatus(parseInt(id), actorUserId, newStatus);
     res.status(200).json({ message: 'Status updated successfully' });
   } catch (error) {
     console.error('Error updating dispute status:', error);
-    res.status(500).json({ error: 'Internal server error' });
+    res.status(500).json({ error: 'Failed to update status' });
   }
 });
 
 // Resolve a dispute
-router.post('/disputes/:id/resolve', requireAuth, requireRole(['moderator', 'admin']), async (req, res) => {
+router.post('/disputes/:id/resolve', async (req, res) => {
   try {
-    await service.resolveDispute(
-      parseInt(req.params.id),
-      req.body,
-      req.user.id
-    );
+    const { id } = req.params;
+    const { actorUserId, ...decisionData } = req.body;
     
+    await DisputeFlowService.resolveDispute(parseInt(id), actorUserId, decisionData);
     res.status(200).json({ message: 'Dispute resolved successfully' });
   } catch (error) {
     console.error('Error resolving dispute:', error);
-    res.status(500).json({ error: 'Internal server error' });
+    res.status(500).json({ error: 'Failed to resolve dispute' });
   }
 });
 
 // Get dispute details
-router.get('/disputes/:id', requireAuth, async (req, res) => {
+router.get('/disputes/:id', async (req, res) => {
   try {
-    const dispute = await service.getDisputeById(parseInt(req.params.id));
+    const { id } = req.params;
+    const dispute = await DisputeFlowService.getDispute(parseInt(id));
     
     if (!dispute) {
       return res.status(404).json({ error: 'Dispute not found' });
@@ -84,18 +69,19 @@ router.get('/disputes/:id', requireAuth, async (req, res) => {
     res.json(dispute);
   } catch (error) {
     console.error('Error fetching dispute:', error);
-    res.status(500).json({ error: 'Internal server error' });
+    res.status(500).json({ error: 'Failed to fetch dispute' });
   }
 });
 
-// Get dispute events history
-router.get('/disputes/:id/events', requireAuth, async (req, res) => {
+// Get dispute events
+router.get('/disputes/:id/events', async (req, res) => {
   try {
-    const events = await service.getDisputeEvents(parseInt(req.params.id));
+    const { id } = req.params;
+    const events = await DisputeFlowService.getDisputeEvents(parseInt(id));
     res.json(events);
   } catch (error) {
     console.error('Error fetching dispute events:', error);
-    res.status(500).json({ error: 'Internal server error' });
+    res.status(500).json({ error: 'Failed to fetch dispute events' });
   }
 });
 

backend/src/dispute-flow/dispute-flow.service.ts

@@ -1,118 +1,120 @@
-import { Dispute, DisputeEvent } from './dispute-flow.model';
-import { db } from '../db';
+import { db } from '../db/database';
+import { Dispute, DisputeEvent, DisputeStatus } from './dispute-flow.model';
 
 export class DisputeFlowService {
-  async createDispute(disputeData: Partial<Dispute>): Promise<Dispute> {
-    const query = `
-      INSERT INTO disputes 
-        (deal_id, opened_by_user_id, status, reason_code, summary, requested_outcome)
-      VALUES (?, ?, ?, ?, ?, ?)
-      RETURNING *
-    `;
+  static async createDispute(disputeData: Omit<Dispute, 'id' | 'status' | 'created_at' | 'updated_at'>): Promise<Dispute> {
+    const { dealId, openedByUserId, reasonCode, summary, requestedOutcome } = disputeData;
     
-    const values = [
-      disputeData.dealId,
-      disputeData.openedByUserId,
-      disputeData.status || 'open',
-      disputeData.reasonCode,
-      disputeData.summary,
-      disputeData.requestedOutcome
-    ];
+    const result = await db.query(
+      `INSERT INTO disputes (deal_id, opened_by_user_id, reason_code, summary, requested_outcome) 
+       VALUES (?, ?, ?, ?, ?)`,
+      [dealId, openedByUserId, reasonCode, summary, requestedOutcome]
+    );
     
-    const result = await db.query(query, values);
-    return result.rows[0];
+    const disputeId = result.insertId;
+    
+    // Create initial event
+    await db.query(
+      `INSERT INTO dispute_events (dispute_id, event_type, actor_user_id, payload_json) 
+       VALUES (?, ?, ?, ?)`,
+      [disputeId, 'dispute_opened', openedByUserId, JSON.stringify({ reasonCode, summary })]
+    );
+    
+    // Fetch and return the created dispute
+    const [disputes] = await db.query<Dispute[]>('SELECT * FROM disputes WHERE id = ?', [disputeId]);
+    return disputes[0];
   }
 
-  async addEvidence(disputeId: number, evidenceData: any, actorUserId: number): Promise<void> {
-    // Insert evidence as a new event
-    const query = `
-      INSERT INTO dispute_events 
-        (dispute_id, event_type, actor_user_id, payload_json)
-      VALUES (?, ?, ?, ?)
-    `;
-    
-    const values = [
-      disputeId,
-      'evidence',
-      actorUserId,
-      JSON.stringify(evidenceData)
-    ];
-    
-    await db.query(query, values);
+  static async addEvidence(disputeId: number, actorUserId: number, evidenceData: any): Promise<void> {
+    // Check if dispute exists and is in correct status
+    const [disputes] = await db.query<Dispute[]>('SELECT status FROM disputes WHERE id = ?', [disputeId]);
+    if (disputes.length === 0) {
+      throw new Error('Dispute not found');
     }
     
-  async updateDisputeStatus(disputeId: number, newStatus: string, actorUserId: number): Promise<void> {
-    // Update the dispute status
-    const query = `
-      UPDATE disputes 
-      SET status = ? 
-      WHERE id = ?
-    `;
-    
-    await db.query(query, [newStatus, disputeId]);
-    
-    // Log the status change as an event
-    const eventQuery = `
-      INSERT INTO dispute_events 
-        (dispute_id, event_type, actor_user_id, payload_json)
-      VALUES (?, ?, ?, ?)
-    `;
-    
-    const values = [
-      disputeId,
-      'status_change',
-      actorUserId,
-      JSON.stringify({ newStatus })
-    ];
-    
-    await db.query(eventQuery, values);
+    const dispute = disputes[0];
+    if (dispute.status !== 'evidence') {
+      throw new Error('Evidence can only be added when dispute status is "evidence"');
     }
     
-  async resolveDispute(disputeId: number, decisionData: any, actorUserId: number): Promise<void> {
-    // Update the dispute with final decision
-    const query = `
-      UPDATE disputes 
-      SET status = 'resolved',
-          final_decision = ?,
-          final_reason = ?,
-          decided_by_user_id = ?,
-          decided_at = NOW()
-      WHERE id = ?
-    `;
-    
-    await db.query(query, [
-      decisionData.decision,
-      decisionData.decisionReason,
-      actorUserId,
-      disputeId
-    ]);
-    
-    // Log the resolution as an event
-    const eventQuery = `
-      INSERT INTO dispute_events 
-        (dispute_id, event_type, actor_user_id, payload_json)
-      VALUES (?, ?, ?, ?)
-    `;
-    
-    const values = [
-      disputeId,
-      'resolved',
-      actorUserId,
-      JSON.stringify(decisionData)
-    ];
-    
-    await db.query(eventQuery, values);
+    await db.query(
+      `INSERT INTO dispute_events (dispute_id, event_type, actor_user_id, payload_json) 
+       VALUES (?, ?, ?, ?)`,
+      [disputeId, 'evidence_added', actorUserId, JSON.stringify(evidenceData)]
+    );
   }
 
-  async getDisputeById(disputeId: number): Promise<Dispute | null> {
-    const query = 'SELECT * FROM disputes WHERE id = ?';
-    const result = await db.query(query, [disputeId]);
-    return result.rows[0] || null;
+  static async updateDisputeStatus(disputeId: number, actorUserId: number, newStatus: DisputeStatus): Promise<void> {
+    // Check if dispute exists
+    const [disputes] = await db.query<Dispute[]>('SELECT status FROM disputes WHERE id = ?', [disputeId]);
+    if (disputes.length === 0) {
+      throw new Error('Dispute not found');
     }
     
-  async getDisputeEvents(disputeId: number): Promise<DisputeEvent[]> {
-    const query = 'SELECT * FROM dispute_events WHERE dispute_id = ? ORDER BY created_at ASC';
-    const result = await db.query(query, [disputeId]);
-    return result.rows;
+    const dispute = disputes[0];
+    
+    // Validate status transition
+    const validTransitions: Record<DisputeStatus, DisputeStatus[]> = {
+      open: ['evidence'],
+      evidence: ['mediation', 'resolved', 'cancelled'],
+      mediation: ['resolved', 'cancelled'],
+      resolved: [],
+      cancelled: []
+    };
+    
+    if (!validTransitions[dispute.status].includes(newStatus)) {
+      throw new Error(`Invalid status transition from ${dispute.status} to ${newStatus}`);
+    }
+    
+    // Update dispute status
+    await db.query('UPDATE disputes SET status = ? WHERE id = ?', [newStatus, disputeId]);
+    
+    // Create event
+    await db.query(
+      `INSERT INTO dispute_events (dispute_id, event_type, actor_user_id, payload_json) 
+       VALUES (?, ?, ?, ?)`,
+      [disputeId, 'status_changed', actorUserId, JSON.stringify({ oldStatus: dispute.status, newStatus })]
+    );
+  }
+
+  static async resolveDispute(disputeId: number, actorUserId: number, decisionData: {
+    decision: string;
+    decisionReason: string;
+  }): Promise<void> {
+    // Check if dispute exists and is in mediation or evidence status
+    const [disputes] = await db.query<Dispute[]>('SELECT status FROM disputes WHERE id = ?', [disputeId]);
+    if (disputes.length === 0) {
+      throw new Error('Dispute not found');
+    }
+    
+    const dispute = disputes[0];
+    if (dispute.status !== 'mediation' && dispute.status !== 'evidence') {
+      throw new Error('Dispute can only be resolved when status is "mediation" or "evidence"');
+    }
+    
+    // Update dispute with final decision
+    await db.query(
+      `UPDATE disputes 
+       SET status = 'resolved', final_decision = ?, final_reason = ?, decided_by_user_id = ?, decided_at = NOW() 
+       WHERE id = ?`,
+      [decisionData.decision, decisionData.decisionReason, actorUserId, disputeId]
+    );
+    
+    // Create event
+    await db.query(
+      `INSERT INTO dispute_events (dispute_id, event_type, actor_user_id, payload_json) 
+       VALUES (?, ?, ?, ?)`,
+      [disputeId, 'dispute_resolved', actorUserId, JSON.stringify(decisionData)]
+    );
+  }
+
+  static async getDispute(disputeId: number): Promise<Dispute | null> {
+    const [disputes] = await db.query<Dispute[]>('SELECT * FROM disputes WHERE id = ?', [disputeId]);
+    return disputes.length > 0 ? disputes[0] : null;
+  }
+
+  static async getDisputeEvents(disputeId: number): Promise<DisputeEvent[]> {
+    const [events] = await db.query<DisputeEvent[]>('SELECT * FROM dispute_events WHERE dispute_id = ? ORDER BY created_at ASC', [disputeId]);
+    return events;
   }
 }