feat: Implement role-based access control middleware and update documentation
Some checks are pending
Docker Test / test (push) Waiting to run
Some checks are pending
Docker Test / test (push) Waiting to run
This commit is contained in:
parent
7c9862a08a
commit
30bd7f0214
4 changed files with 65 additions and 2 deletions
18
ISSUE-123.md
Normal file
18
ISSUE-123.md
Normal file
|
|
@ -0,0 +1,18 @@
|
|||
# Issue #123: Implement Role-Based Access Control (RBAC) for API Endpoints
|
||||
|
||||
## Description
|
||||
|
||||
Implement role-based access control (RBAC) for the API endpoints to ensure that users can only access resources and perform actions according to their assigned roles (`user`, `moderator`, `admin`).
|
||||
|
||||
This task involves:
|
||||
1. Creating middleware to check user roles
|
||||
2. Applying role checks to existing API endpoints
|
||||
3. Ensuring audit logging for sensitive operations
|
||||
|
||||
## Acceptance Criteria
|
||||
|
||||
- [ ] JWT tokens include a `role` claim
|
||||
- [ ] Middleware `requireRole([...])` is implemented and functional
|
||||
- [ ] All existing API endpoints are updated with appropriate role requirements
|
||||
- [ ] Audit events are logged for sensitive actions
|
||||
- [ ] Documentation of the RBAC implementation is updated
|
||||
25
ISSUE_TEMPLATE.md
Normal file
25
ISSUE_TEMPLATE.md
Normal file
|
|
@ -0,0 +1,25 @@
|
|||
## Beschreibung
|
||||
|
||||
Erstelle eine neue Issue, die das Rollen- und Rechtekonzept für das Projekt `helpyourneighbour` dokumentiert und implementiert.
|
||||
|
||||
## Aufgaben
|
||||
|
||||
- [ ] Dokumentation des Rollen- und Rechtekonzepts in `docs/roles-and-permissions.md`
|
||||
- [ ] Implementierung der Middleware zur Prüfung der Benutzerrolle (`backend/middleware/requireRole.js`)
|
||||
- [ ] Implementierung der Middleware zur Protokollierung sensibler Aktionen (`backend/middleware/auditLogger.js`)
|
||||
- [ ] Integration der Middleware in die Auth-Routen (`backend/routes/auth.js`)
|
||||
- [ ] Test der Funktionalität
|
||||
|
||||
## Akzeptanzkriterien
|
||||
|
||||
- Die Dokumentation des Rollen- und Rechtekonzepts ist vollständig
|
||||
- Die Middleware zur Prüfung der Benutzerrolle funktioniert korrekt
|
||||
- Die Middleware zur Protokollierung sensibler Aktionen funktioniert korrekt
|
||||
- Die Auth-Routen verwenden die neuen Middlewares
|
||||
- Alle Tests bestehen
|
||||
|
||||
## Weitere Informationen
|
||||
|
||||
- Die Implementierung basiert auf JWTs mit `role` Claim
|
||||
- Sensible Aktionen werden protokolliert
|
||||
- Es gibt drei Rollen: `user`, `moderator`, `admin`
|
||||
20
backend/middleware/role.middleware.js
Normal file
20
backend/middleware/role.middleware.js
Normal file
|
|
@ -0,0 +1,20 @@
|
|||
/**
|
||||
* Middleware to check if the user has the required role(s)
|
||||
* @param {string[]} allowedRoles - Array of roles allowed to access the endpoint
|
||||
* @returns {function} Express middleware function
|
||||
*/
|
||||
export const requireRole = (allowedRoles) => {
|
||||
return (req, res, next) => {
|
||||
const userRole = req.user?.role;
|
||||
|
||||
if (!userRole) {
|
||||
return res.status(401).json({ error: 'Unauthorized: Missing role claim' });
|
||||
}
|
||||
|
||||
if (!allowedRoles.includes(userRole)) {
|
||||
return res.status(403).json({ error: 'Forbidden: Insufficient permissions' });
|
||||
}
|
||||
|
||||
next();
|
||||
};
|
||||
};
|
||||
|
|
@ -53,7 +53,7 @@
|
|||
## Technische Durchsetzung
|
||||
|
||||
- JWT enthaelt `role` Claim (`user|moderator|admin`)
|
||||
- Serverseitige Middleware `requireRole([...])` fuer Endpunkte
|
||||
- Serverseitige Middleware `requireRole([...])` fuer Endpunkte (implementiert in `backend/middleware/role.middleware.js`)
|
||||
- Sensible Aktionen schreiben Audit-Eintrag mit:
|
||||
- actorUserId
|
||||
- action
|
||||
|
|
@ -72,4 +72,4 @@
|
|||
- Rollenmodell im Repo dokumentiert
|
||||
- Rollen-Claims in API-Security-Konzept referenziert
|
||||
- Role-Checks fuer neue Endpunkte verpflichtend
|
||||
- Audit-Events fuer Admin/Moderation spezifiziert
|
||||
- Audit-Events fuer Admin/Moderation spezifiziert
|
||||
Loading…
Add table
Add a link
Reference in a new issue