Add unit tests for role middleware

backend/tests/roles.test.js

@@ -1,25 +1,82 @@
 const request = require('supertest');
-const app = require('../app.js');
+const app = require('../app');
 
-describe('Role-based Access Control', () => {
-  describe('User Role', () => {
-    test('should allow user to access user-specific endpoints', async () => {
-      // This is a placeholder test - actual implementation would need JWT setup
-      expect(true).toBe(true);
-    });
+describe('Role Middleware', () => {
+  // Mock a user with a specific role for testing
+  const mockUserWithRole = (role) => {
+    return {
+      role: role,
+      id: 'test-user-id'
+    };
+  };
+
+  // Test that the middleware allows access to users with correct roles
+  test('should allow access to users with correct roles', () => {
+    const req = {
+      user: mockUserWithRole('admin')
+    };
+    const res = {
+      status: jest.fn().mockReturnThis(),
+      json: jest.fn()
+    };
+    const next = jest.fn();
+
+    const middleware = require('../middleware/role.middleware');
+    middleware.requireRole(['admin'])(req, res, next);
+
+    expect(next).toHaveBeenCalled();
   });
 
-  describe('Moderator Role', () => {
-    test('should allow moderator to access moderation endpoints', async () => {
-      // This is a placeholder test - actual implementation would need JWT setup
-      expect(true).toBe(true);
-    });
+  // Test that the middleware denies access to users with incorrect roles
+  test('should deny access to users with incorrect roles', () => {
+    const req = {
+      user: mockUserWithRole('user')
+    };
+    const res = {
+      status: jest.fn().mockReturnThis(),
+      json: jest.fn()
+    };
+    const next = jest.fn();
+
+    const middleware = require('../middleware/role.middleware');
+    middleware.requireRole(['admin'])(req, res, next);
+
+    expect(res.status).toHaveBeenCalledWith(403);
+    expect(res.json).toHaveBeenCalledWith({ error: 'Forbidden' });
   });
 
-  describe('Admin Role', () => {
-    test('should allow admin to access admin endpoints', async () => {
-      // This is a placeholder test - actual implementation would need JWT setup
-      expect(true).toBe(true);
-    });
+  // Test that the middleware denies access to users without roles
+  test('should deny access to users without roles', () => {
+    const req = {
+      user: null
+    };
+    const res = {
+      status: jest.fn().mockReturnThis(),
+      json: jest.fn()
+    };
+    const next = jest.fn();
+
+    const middleware = require('../middleware/role.middleware');
+    middleware.requireRole(['admin'])(req, res, next);
+
+    expect(res.status).toHaveBeenCalledWith(401);
+    expect(res.json).toHaveBeenCalledWith({ error: 'Unauthorized' });
+  });
+
+  // Test that the middleware allows access to users with one of multiple required roles
+  test('should allow access to users with one of multiple required roles', () => {
+    const req = {
+      user: mockUserWithRole('moderator')
+    };
+    const res = {
+      status: jest.fn().mockReturnThis(),
+      json: jest.fn()
+    };
+    const next = jest.fn();
+
+    const middleware = require('../middleware/role.middleware');
+    middleware.requireRole(['admin', 'moderator'])(req, res, next);
+
+    expect(next).toHaveBeenCalled();
   });
 });