openclaw/helpyourneighbour
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat: Add role-based access control middleware and tests
Some checks are pending
Docker Test / test (push) Waiting to run
Details

Browse source
This commit is contained in:
BibaBot 2026-03-17 22:08:53 +00:00
parent 901bcf454c
commit eb45e4474d
6 changed files with 58 additions and 165 deletions
Download patch file Download diff file Expand all files Collapse all files

88
backend/tests/roles.test.js
View file

@ -1,88 +0,0 @@
import request from 'supertest';
import app from '../app.js';
import { requireRole } from '../middleware/role.middleware.js';
describe('Role-based Access Control', () => {
// Test that the middleware is properly exported
test('requireRole should be a function', () => {
expect(typeof requireRole).toBe('function');
});
// Mock user authentication for testing
const mockUser = (role) => {
return {
role: role,
id: 'test-user-id'
};
};
// Test that middleware allows access to users with correct roles
test('should allow access to users with correct roles', () => {
const req = {
user: mockUser('admin')
};
const res = {
status: jest.fn().mockReturnThis(),
json: jest.fn()
};
const next = jest.fn();
const middleware = requireRole(['admin']);
middleware(req, res, next);
expect(next).toHaveBeenCalled();
});
// Test that middleware denies access to users with incorrect roles
test('should deny access to users with incorrect roles', () => {
const req = {
user: mockUser('user')
};
const res = {
status: jest.fn().mockReturnThis(),
json: jest.fn()
};
const next = jest.fn();
const middleware = requireRole(['admin']);
middleware(req, res, next);
expect(res.status).toHaveBeenCalledWith(403);
expect(res.json).toHaveBeenCalledWith({ error: 'Insufficient permissions' });
});
// Test that middleware denies access to unauthenticated users
test('should deny access to unauthenticated users', () => {
const req = {
user: null
};
const res = {
status: jest.fn().mockReturnThis(),
json: jest.fn()
};
const next = jest.fn();
const middleware = requireRole(['admin']);
middleware(req, res, next);
expect(res.status).toHaveBeenCalledWith(401);
expect(res.json).toHaveBeenCalledWith({ error: 'Authentication required' });
});
// Test that middleware allows access to users with one of multiple roles
test('should allow access to users with one of multiple roles', () => {
const req = {
user: mockUser('moderator')
};
const res = {
status: jest.fn().mockReturnThis(),
json: jest.fn()
};
const next = jest.fn();
const middleware = requireRole(['admin', 'moderator']);
middleware(req, res, next);
expect(next).toHaveBeenCalled();
});
});